continue syncing issues even if default asset version lookup fails - #2821
Open
refoo0 wants to merge 1 commit into
Open
continue syncing issues even if default asset version lookup fails#2821refoo0 wants to merge 1 commit into
refoo0 wants to merge 1 commit into
Conversation
Signed-off-by: rafi <refaei.shikho@hotmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the asset update flow to avoid aborting the background ticket/issue synchronization when the default asset version lookup fails.
Changes:
- Downgrades the log from
ErrortoWarnwhenGetDefaultAssetVersionfails in theUpdatebackground task. - Removes the early
returnon default asset version lookup failure (so the subsequent sync call continues).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+399
to
403
| // we don't want to return an error here, because we still want to update the asset in the database | ||
| slog.Warn("could not get default asset version", "err", err) | ||
| } | ||
|
|
||
| if err := a.dependencyVulnService.SyncAllIssues(linkedCtx, org, project, asset, defaultAssetVersion, &userAgent); err != nil { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.