Skip to content

continue syncing issues even if default asset version lookup fails #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
refoo0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

continue syncing issues even if default asset version lookup fails #2821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions controllers/asset_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,8 +396,8 @@ func (a *AssetController) Update(ctx shared.Context) error {
a.FireAndForget(func() {
defaultAssetVersion, err := a.assetVersionRepository.GetDefaultAssetVersion(linkedCtx, nil, asset.ID)
if err != nil {
slog.Error("could not get default asset version", "err", err)
return
// we don't want to return an error here, because we still want to update the asset in the database
slog.Warn("could not get default asset version", "err", err)
}

if err := a.dependencyVulnService.SyncAllIssues(linkedCtx, org, project, asset, defaultAssetVersion, &userAgent); err != nil {
Comment on lines +399 to 403
Expand Down
Loading