Skip to content

Bump Samtools to v1.24#12340

Open
matthdsm wants to merge 39 commits into
masterfrom
bump/samtools-1.24
Open

Bump Samtools to v1.24#12340
matthdsm wants to merge 39 commits into
masterfrom
bump/samtools-1.24

Conversation

@matthdsm

@matthdsm matthdsm commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@mashehu

mashehu commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

too fast! there is a PR to make your life easier in the pipeline nf-core/tools#4374

@matthdsm

Copy link
Copy Markdown
Contributor Author

Samtools waits for no man!
Also, this release features my first contribution to samtools, which I've kind of wanted for a while 😄

@mashehu

mashehu commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Congrats! (now you can time then even better with hackathons 😉)

@matthdsm

Copy link
Copy Markdown
Contributor Author

Sadly I have no control over release timings 😅 Otherwise I'd release ALL the tools during the hackathon. Give people smth to do

@matthdsm

Copy link
Copy Markdown
Contributor Author

SOOOOOO many broken tests 😲

@matthdsm matthdsm marked this pull request as ready for review July 10, 2026 06:01
@matthdsm

Copy link
Copy Markdown
Contributor Author

@nf-core-bot update gpu snapshot path: subworkflows/nf-core/fastq_align_dedup_bwameth/tests/gpu.nf.test

@matthdsm

Copy link
Copy Markdown
Contributor Author

Some failures remain:

  • singularity containers have no gzip for some reason 🤔
  • subwf using bwa_align keep failing, even though the tests pass locally

@maxulysse

Copy link
Copy Markdown
Member

Still a linting issue for samtools/bam2fq

@maxulysse

Copy link
Copy Markdown
Member

@nf-core-bot update gpu snapshot path: subworkflows/nf-core/fastq_align_dedup_bwamem/tests/gpu.nf.test

Comment thread modules/nf-core/samtools/samples/environment.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants