fix: consume keychain exists mitigation#405
Merged
Merged
Conversation
Contributor
Author
|
Depends on open-cli-collective/cli-common#65. Once that merges, I will repin this PR to the resulting main-branch commit before merge so the dependency is not left on an orphaned pseudo-version. |
Automated PR ReviewReviewed commit: Summary
Reviewer Coverage
0 PR discussion threads considered. 0 summarized; 0 resolved. Completed in 2m 10s | unavailable | gpt-5.4 | cr 0.10.196
Per-workstream usage
|
f27b7f6 to
4f05f43
Compare
Automated PR ReviewReviewed commit: Summary
Reviewer Coverage
0 PR discussion threads considered. 0 summarized; 0 resolved. Completed in 1m 35s | unavailable | gpt-5.4 | cr 0.10.197
Per-workstream usage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #404
Summary
cli-commonStore.Existsmitigation released inv0.4.1, which prefers metadata/ref-only lookups over secret readsVerification
go test ./...make buildmake lintExistsbehavior at about 6.3s versus about 10ms with the patched dependency