Skip to content

fix: consume keychain exists mitigation #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rianjs merged 4 commits into from
Jun 30, 2026
Merged

fix: consume keychain exists mitigation #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68f0b76
fix: consume keychain exists mitigation
rianjs Jun 29, 2026
8025013
fix: repin cli-common keychain mitigation commit
rianjs Jun 29, 2026
73cb031
fix: repin cli-common after nocgo metadata fix
rianjs Jun 29, 2026
4f05f43
fix: use cli-common v0.4.1
rianjs Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ builds:
- -X github.com/open-cli-collective/codereview-cli/internal/version.Version={{.Version}}
- -X github.com/open-cli-collective/codereview-cli/internal/version.Commit={{.Commit}}
- -X github.com/open-cli-collective/codereview-cli/internal/version.Date={{.Date}}
# macOS code-signing — stable DR so Keychain "Always Allow" survives brew upgrade
# (cli-common distribution.md §2A). Logic + identity live in open-cli-collective/.github
# macOS code-signing — stable DR avoids ad-hoc identity churn, but self-signed
# builds still need the shared Keychain prompt mitigations described in
# cli-common/docs/distribution.md §2A. Logic + identity live in open-cli-collective/.github
# (macos-codesign-setup), which exports CODESIGN_DARWIN_SCRIPT (absolute). Unset in
# local builds → signing skipped.
hooks:
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ require (
github.com/charmbracelet/lipgloss v1.1.0
github.com/creack/pty v1.1.24
github.com/google/uuid v1.6.0
github.com/open-cli-collective/cli-common v0.4.0
github.com/open-cli-collective/cli-common v0.4.1
github.com/spf13/cobra v1.10.2
golang.org/x/sys v0.46.0
golang.org/x/term v0.44.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e h1:fD57ERR4JtEqsWb
github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e/go.mod h1:zD1mROLANZcx1PVRCS0qkT7pwLkGfwJo4zjcN/Tysno=
github.com/noamcohen97/touchid-go v0.3.0 h1:fcXxVCizysD7KHRR6hrURt3nyNIs5JBGSbOIidD/3wo=
github.com/noamcohen97/touchid-go v0.3.0/go.mod h1:X9MRNIBGEmPqwpDm1G3fQOAQX7fwBlhzUbnkDTxuta0=
github.com/open-cli-collective/cli-common v0.4.0 h1:YkffqDW2OmFMWPqrT7m/yC3VoUKxGRAp26i2QZMYIWo=
github.com/open-cli-collective/cli-common v0.4.0/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ=
github.com/open-cli-collective/cli-common v0.4.1 h1:6oNaUVmMtXWi4pJn1X+W6KZVDP/WAJwbyZUyxYpGdbQ=
github.com/open-cli-collective/cli-common v0.4.1/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ=
github.com/opentracing/opentracing-go v1.2.0 h1:uEJPy/1a5RIPAJ0Ov+OIO8OxWu77jEv+1B0VhjKrZUs=
github.com/opentracing/opentracing-go v1.2.0/go.mod h1:GxEUsuufX4nBwe+T+Wl9TAgYrxe9dPLANfrWvHYVTgc=
github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
Expand Down
Loading