Use a fixture account in the access-list tests, not this machine's - #10
Merged
Conversation
The sample `icacls` output was pasted from the machine the feature was written on, so a real hostname and account name went into a public repository as test data. Neither tells the reader anything the fixture needs: what matters is the shape — a path and a first entry sharing one line, indented entries after it, an account name containing a space. Replaced with `EXAMPLE-PC\Sam`. The earlier commit still carries the original in history; rewriting that is a separate decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sample
icaclsoutput in the Windows access-list tests was pasted from the machine the feature was written on, so a real hostname and account name went into a public repository as test data.Neither tells the reader anything the fixture needs. What these tests describe is the shape of the output — a path and a first entry sharing one line, indented entries after it, an account name containing a space — and
EXAMPLE-PC\Samcarries all of that.Note that the earlier commit still holds the original in history. Rewriting that is a separate decision, not made here.