Skip to content

Use a fixture account in the access-list tests, not this machine's #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btriapitsyn merged 1 commit into from
Aug 7, 2026
Merged

Use a fixture account in the access-list tests, not this machine's #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/windows-acl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ async function currentAccountSid() {
*
* C:\…\workspaces Everyone:(OI)(CI)(F)
* NT AUTHORITY\SYSTEM:(I)(OI)(CI)(F)
* DESKTOP-CP9J2I4\Bohdan Triapitsyn:(I)(OI)(CI)(F)
* EXAMPLE-PC\Sam:(I)(OI)(CI)(F)
*
* The path has to come off first: it contains the drive's colon, and a principal may
* contain spaces, so there is no separator that tells them apart on that first line.
Expand Down
6 changes: 3 additions & 3 deletions src/windows-acl.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,20 +29,20 @@ describe('windows state protection', () => {
});

it('reads every principal out of a list, including one whose name has a space', () => {
const path = 'C:\\Users\\BOHDAN~1\\AppData\\Local\\Temp\\acl-probe';
const path = 'C:\\Users\\Sam\\AppData\\Local\\Temp\\acl-probe';
const output = [
`${path} Everyone:(OI)(CI)(F)`,
' NT AUTHORITY\\SYSTEM:(I)(OI)(CI)(F)',
' BUILTIN\\Administrators:(I)(OI)(CI)(F)',
' DESKTOP-CP9J2I4\\Bohdan Triapitsyn:(I)(OI)(CI)(F)',
' EXAMPLE-PC\\Sam:(I)(OI)(CI)(F)',
'',
'Successfully processed 1 files; Failed processing 0 files',
].join('\r\n');
expect(parseGrantedPrincipals(output, path)).toEqual([
'Everyone',
'NT AUTHORITY\\SYSTEM',
'BUILTIN\\Administrators',
'DESKTOP-CP9J2I4\\Bohdan Triapitsyn',
'EXAMPLE-PC\\Sam',
]);
});

Expand Down
Loading