Rollup of 28 pull requests#159966
Conversation
Use `local_to_op` and the operand storage shape to render initialized immediate locals through Miri's Immediate display implementation. Keep mplace-backed locals as `<indirect>` for now, preserve explicit dead/uninit states, and expose interpreter errors in `LocalDesc`.value. Add value-shape and metadata-sized local fixtures for the next indirect rendering slices.
Resolve allocation-backed mplace locals and display their allocation contents with dump_alloc. Keep unsupported provenance as <indirect> and update the fixtures for the temporary diagnostic allocation output.
This updates the rust-version file to c904ba3.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@c904ba3 Filtered ref: rust-lang/miri@d686e0d Upstream diff: rust-lang/rust@4a9d536...c904ba3 This merge was created using https://github.com/rust-lang/josh-sync.
Automatic Rustup
Replace the diagnostic dump_alloc output with a Priroda-owned byte renderer for mplace-backed locals. Compute the current value size with size_and_align_of_val, inspect only the mplace byte range, and render uninitialized bytes with an explicit marker.
Render complete pointer provenance while dumping indirect local values. Preserve initialized and uninitialized byte ranges, including padding and partial pointer bytes, and report unsupported unsized values explicitly. Add UI coverage for pointer positions, nonzero target offsets, uninitialized regions, and partial provenance.
Add a `follow` command that renders allocation bytes starting at a given allocation offset, reusing the provenance-aware allocation byte renderer used for indirect locals. Document the command and cover following a rendered pointer allocation in the pointer-rendering UI test.
…dling [Priroda] Render indirect local values
support `neon.tbl*` intrinsics
When using `RUSTFLAGS="-Ctarget-features=+avx512f"`, the Rust compiler
complains:
error: unknown codegen option: `target-features`
The actual option uses the singular form.
…eature-typo readme: fix misspelling of `-Ctarget-feature`
add a riscv target to CI
This updates the rust-version file to 1af98b7.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@1af98b7 Filtered ref: rust-lang/miri@c4103d8 Upstream diff: rust-lang/rust@c904ba3...1af98b7 This merge was created using https://github.com/rust-lang/josh-sync.
…nsic support" This reverts commit 785e740bb5c1d9166717c93612f7b9f99fee1caf. The additional intrinsic support has meanwhile been implemented.
This commit is a change for all WASI targets to use a different underlying implementation in the standard library for `thread_local!`. Previously all wasm targets, without the `atomics` feature, were funneled into the `no_threads` implementation and various fallbacks in the `thread_local` module. The upcoming `wasm32-wasip3` target, however, will actually have threads and will need different treatment. Additionally the modules that `wasm32-wasip3` needs all already work on all other WASI targets as well -- for example the `pthread_*` symbols needed to manage destructors are exposed by `wasi-libc`. The end result is that the `wasm32-wasip3` target will be "ready for threads" as soon as `wasi-libc` has support. Other targets shouldn't have any functional difference from before, too.
This updates the rust-version file to 390279b.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@390279b Filtered ref: rust-lang/miri@161dd69 Upstream diff: rust-lang/rust@1af98b7...390279b This merge was created using https://github.com/rust-lang/josh-sync.
Add a CLI fixture covering a projected memory-backed field inside a larger aggregate. This locks in that projected values render only their own MPlace layout bytes instead of trailing bytes from the parent allocation.
Keep projected MIR Places long enough to evaluate them with `eval_place_to_op`, then reuse the existing raw operand renderer for immediate and memory-backed values. This removes `<unsupported-projection>` from projected locals, including fields, enum projections, references, and dereferences. Update the projected debug-info UI expectations and verify the full Priroda suite.
Automatic Rustup
[Priroda] Render projected debug-info values
|
Omg it's spurious that explains why it was so weird... |
|
❗ You can only retry pull requests that are approved and have a previously failed auto build. |
|
@bors r+ |
|
@bors treeopen |
|
Tree is now open for merging. |
This comment has been minimized.
This comment has been minimized.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
📌 Perf builds for each rolled up PR:
previous master: dc3f85158a In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
Finished benchmarking commit (dfbea5b): comparison URL. Overall result: ❌ regressions - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.1%, secondary 2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 489.277s -> 486.74s (-0.52%) |
View all comments
Successful merges:
Steptrait into multiple traits #159638 (bootstrap: Split theSteptrait into multiple traits)#[linkage]target checking #159617 (Fix up#[linkage]target checking)thread_local!for WASI #159733 (std: Switch implementations ofthread_local!for WASI)#[rustc_paren_sugar]feature gate #159826 (Remove redundant#[rustc_paren_sugar]feature gate)str::copy_from_str#159846 (Implementstr::copy_from_str)Optionfrom statement parsing #159849 (rustc_parse: Stop returningOptionfrom statement parsing)CStringstruct and method documentation #159853 (Updated expect messages forCStringstruct and method documentation)rustc_attr_parsing#159875 (More cleanup inrustc_attr_parsing)find_attrhygiene andrustc_hircleanups #159893 (Fixfind_attrhygiene andrustc_hircleanups)rustc_ast::astdoc cleanups #159936 (Minorrustc_ast::astdoc cleanups)r? @ghost
Create a similar rollup