Remove various superfluous lint attributes - #160085
Conversation
|
Some changes occurred in exhaustiveness checking cc @Nadrieril Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri
Some changes occurred to the CTFE machinery |
rustbot
added
A-translation
|
r? @mu001999 rustbot has assigned @mu001999. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| // Unlike all the other GC helpers where we check if an `AllocId` is found in the interpreter or | ||
| // is live, here all the IDs in the map are for dead allocations so we don't | ||
| // need to check for liveness. | ||
| #[allow(rustc::potential_query_instability)] // Only used from Miri, not queries. |
|
Nice cleanup! r=me after CI green |
|
By the way, I'm wondering how you found these to be superfluous |
You start removing random allows and see whether something starts screaming at you 😜 |
| // tidy-alphabetical-start | ||
| #![allow(unused_crate_dependencies)] | ||
| // tidy-alphabetical-end |
There was a problem hiding this comment.
Note that this is a librarified crate that may be compiled without the rustc feature. But I guess that flag is allowed by default in a normal compilation so maybe that's not relevant? I'm just wondering why it was there in the first place
There was a problem hiding this comment.
Looks like CI fails due to this.
There was a problem hiding this comment.
It was added with the implementation of rust-lang/compiler-team#844, why I do not know. Sometimes with those cleanup prs it's preferable to add an allow here and there to avoid expanding the scope of the pr too much
and this is why:
warning: extern crate `tracing_subscriber` is unused in crate `rustc_pattern_analysis`
|
= help: remove the dependency or add `use tracing_subscriber as _;` to the crate root
= note: requested on the command line with `-W unused-crate-dependencies`
warning: extern crate `tracing_tree` is unused in crate `rustc_pattern_analysis`
|
= help: remove the dependency or add `use tracing_tree as _;` to the crate root
There was a problem hiding this comment.
Hm, seems like this was added because of a false positive when compiling the compiler. So it used to trigger, and seems like it doesn't anymore, so it should be fine to remove. The only commit that vaguely could affect this since then is 67c6cd9 maybe? I'm ok with removing it at least.
There was a problem hiding this comment.
Oh, y'all were so fast :D If it's these crates it's because they're used in tests. But they're explicitly used, idk why they'd trigger the warning.
There was a problem hiding this comment.
They're only used in integration tests (not unit tests), that's probably why. I'll try to figure something out or back it out and add a comment.
This comment has been minimized.
This comment has been minimized.
|
@bors r+ rollup |
rust-bors
Bot
added
S-waiting-on-bors
Remove various superfluous lint attributes
Remove various superfluous lint attributes
Rollup of 6 pull requests Successful merges: - #158460 (Remove llvm_enzyme feature outside of bootstrap) - #159671 (Add semver check test command for checking API compatibility of stdlib) - #159717 (Add `-Zimplicit-sysroot-deps`) - #159994 (Show jobs where a given test was executed in `test-dashboard`) - #160085 (Remove various superfluous lint attributes) - #160123 (add additional license option for third-party dependencies)
|
💔 I suspect this PR failed tests as part of a rollup After fixing the problem, consider running a try job for the failed job before re-approving. Link to failure: #160135 (comment) |
rust-bors
Bot
added
S-waiting-on-author
|
This pull request was unapproved. This PR was contained in a rollup (#160135), which was unapproved. |
6 participants
No description provided.