Skip to content

Show the macOS Computer Name in Switchify Android - #559

Merged
enaboapps merged 2 commits into
mainfrom
agent/macos-computer-name-558
Aug 10, 2026
Merged

Show the macOS Computer Name in Switchify Android#559
enaboapps merged 2 commits into
mainfrom
agent/macos-computer-name-558

Conversation

@enaboapps

@enaboapps enaboapps commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • resolve the localized macOS Computer Name once at runtime startup
  • publish it through the existing GATT status displayName
  • keep the unauthenticated BLE advertisement name fixed as Switchify PC
  • retain Switchify PC as the blank/unavailable fallback

Root cause

CoreBluetooth exposes a generic GAP name (Mac) to Android. The desktop status payload also used a fixed product name, so Android had no authoritative friendly machine name.

Privacy and compatibility

The personalized name is not broadcast in BLE advertising or logged. No protocol version, UUID, desktop identity, pairing, storage, Windows behavior, or diagnostics change. Coordinated Android fix: switchifyapp/switchify-android#2774.

Validation

  • npm run lint
  • npm test -- --run (55 passed)
  • npm run build
  • cargo fmt --manifest-path src-tauri/Cargo.toml --check
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets -- -D warnings
  • cargo test --manifest-path src-tauri/Cargo.toml (140 passed)
  • signed npm run macos:run bundle and designated-requirement verification

Closes #558

@enaboapps

Copy link
Copy Markdown
Contributor Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Aug 10, 2026

Copy link
Copy Markdown

Greptile Summary

This change makes the Mac’s localized computer name available in the connected GATT status response while retaining the generic Switchify PC BLE advertisement name. The earlier host-name exposure report is disproved: the executed comparison confirmed that nearby BLE advertisements no longer use the personalized computer name.

Confidence Score: 5/5

No blocking failure remains.

The executed validation confirmed the fixed advertising name and personalized connected status payload, with no accepted blocking findings.

T-Rex T-Rex Logs

What T-Rex did

  • Ran the focused BLE privacy validation harness against both the parent revision and the current worktree.
  • Compared the two runs and observed that the parent revision exited with code 1 due to the advertisement local name not being the fixed fallback, while the current worktree exited with code 0 and produced a status payload with displayName set to Owen’s Mac Studio, keeping Switchify PC as the advertisement local name.
  • Validated the results against the before-and-after log artifacts using the harness source ble-privacy-validation.py, confirming the before run failed and the after run succeeded, with explicit file references ble-privacy-01-before.log and ble-privacy-02-after.log.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (3): Last reviewed commit: "Keep the BLE advertisement name private" | Re-trigger Greptile

Comment thread src-tauri/src/macos.rs Outdated
Address Greptile P1 by retaining the personalized computer name only in the status characteristic.
@enaboapps

Copy link
Copy Markdown
Contributor Author

@greptileai review

@enaboapps

Copy link
Copy Markdown
Contributor Author

Final status for 26eb7fd:

  • Greptile 5/5
  • frontend CI passed
  • macOS app/DMG CI passed
  • Windows UIAccess/NSIS CI passed
  • all review threads resolved
  • signed local macOS bundle verified and running

Left as a draft for review.

@enaboapps
enaboapps marked this pull request as ready for review August 10, 2026 14:28
@enaboapps
enaboapps merged commit a8f29de into main Aug 10, 2026
4 checks passed
@enaboapps
enaboapps deleted the agent/macos-computer-name-558 branch August 10, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prefer the Switchify computer name for macOS PCs Advertise the macOS Computer Name to Switchify Android

1 participant