fix(chart): agent-daemonset maxUnavailable:0 when surging (JEF-529)#269
Merged
thejefflarson merged 1 commit intoJul 26, 2026
Conversation
DaemonSet rollingUpdate rejects both maxSurge and maxUnavailable being non-zero simultaneously. With the default agent.maxSurge:1, this chart never set maxUnavailable, so it defaulted to 1 — an invalid combination that Kubernetes rejects at apply time. Brings the source chart to parity with the cluster fork's identical fix: surge ⇒ maxUnavailable:0, no surge ⇒ maxUnavailable:1 (default terminate-then-replace). Closes JEF-529 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
thejefflarson
deleted the
thejefflarson/jef-529-repo-chart-parity-agent-daemonset-maxunavailable0-when
branch
July 26, 2026 22:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
charts/protector/templates/agent-daemonset.yaml'supdateStrategy.rollingUpdatesetmaxSurgebut nevermaxUnavailable, which defaults to 1. Kubernetes rejects a DaemonSet rollingUpdate with both non-zero ("maxSurge may not be set when maxUnavailable is non-zero"), so the chart was invalid-if-applied with the defaultagent.maxSurge: 1.This adds the same conditional the cluster fork already carries, bringing the source chart to parity: surging (
maxSurge > 0) setsmaxUnavailable: 0; no surge falls back to the k8s defaultmaxUnavailable: 1(terminate-then-replace).Test plan
helm template charts/protector --set ingestAuth.token=dummy --set agent.enabled=true→maxSurge: 1,maxUnavailable: 0helm template charts/protector --set ingestAuth.token=dummy --set agent.enabled=true --set agent.maxSurge=0→maxSurge: 0,maxUnavailable: 1helm lint charts/protector --set ingestAuth.token=dummy --set agent.enabled=true→ clean (0 charts failed)git diff --staton this branch touches onlyagent-daemonset.yaml(+4 lines)🤖 Generated with Claude Code
https://claude.ai/code/session_01VtjoJttCvBY4dzCoE4f9vP