Skip to content

fix(chart): agent-daemonset maxUnavailable:0 when surging (JEF-529) #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thejefflarson merged 1 commit into from
Jul 26, 2026
+4 −0
Merged

fix(chart): agent-daemonset maxUnavailable:0 when surging (JEF-529) #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/protector/templates/agent-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ spec:
type: RollingUpdate
rollingUpdate:
maxSurge: {{ .Values.agent.maxSurge }}
# A DaemonSet rollingUpdate may not have both maxSurge and maxUnavailable
# non-zero (Kubernetes rejects it). Surging ⇒ maxUnavailable:0; no surge ⇒
# fall back to the default terminate-then-replace (maxUnavailable:1).
maxUnavailable: {{ if gt (int .Values.agent.maxSurge) 0 }}0{{ else }}1{{ end }}
selector:
matchLabels:
{{- include "protector.agentSelectorLabels" . | nindent 6 }}
Expand Down