Skip to content

[CC-3759] Change Keypair properties from private to protected#234

Merged
Ryouzanpaku merged 3 commits into
mainfrom
CC-3759/keypair-protected-properties
Jun 22, 2026
Merged

[CC-3759] Change Keypair properties from private to protected#234
Ryouzanpaku merged 3 commits into
mainfrom
CC-3759/keypair-protected-properties

Conversation

@Ryouzanpaku

@Ryouzanpaku Ryouzanpaku commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Changes all 10 properties in Keypair from private to protected, enabling expose() to pick them up via reflection
  • Extend unit/integration test verifying JSONSerialization works as expected

…le JSON serialization via expose().

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Ryouzanpaku and others added 2 commits June 19, 2026 10:12
…led property visibility

- Change `detailed` to private since it is a fetch-control flag and must not be serialized
- Add unit test verifying expose() includes all protected properties with correct values and excludes privateKey and detailed
- Add integration test verifying expose() reflects fetched keypair data including nested payment type objects

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Ryouzanpaku Ryouzanpaku changed the title Change Keypair properties from private to protected [CC-3759] Change Keypair properties from private to protected Jun 19, 2026
@Ryouzanpaku Ryouzanpaku merged commit d9ef830 into main Jun 22, 2026
13 of 18 checks passed
@Ryouzanpaku Ryouzanpaku deleted the CC-3759/keypair-protected-properties branch June 22, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants