[None][test] Remove 85 closed-bug waive entries for main - #17444
Conversation
Closed bug(s): 5908070, 6075431, 6215684, 6248827, 6255417, 6273846, 6276983, 6301807, 6322073, 6400067, 6414760, 6418021, 6422339, 6423845, 6428087, 6440089, 6442073, 6463812, 6463822, 6463829, 6474892, 6475621, 6478645, 6482297, 6483370, 6490004, 6490043, 6501837, 6507102, 6517839, 6525007, 6525009, 6525892, 6526186, 6526429, 6528834, 6528837, 6529871, 6546605, 6547150, 6547151, 6551802, 6562582, 6563551 Requested by: qa@nvidia.com Jenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_UPDATE_WAIVES/115/ Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
4bbca16 to
b4604ff
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe integration waiver list removes obsolete skipped tests and updates model, hardware, disaggregation, multimodal, performance, documentation, auto-deploy, KV-cache, and unit-test entries. No executable logic changes. ChangesIntegration waiver list refresh
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #64910 [ run ] triggered by Bot. Commit: |
brnguyen2
left a comment
brnguyen2
left a comment
There was a problem hiding this comment.
Approving — the comments below are optional touch-ups, not blockers.
Mechanical, and the file is consistent after the removal — none of the 44 un-waived bug IDs still appear in waives.txt, so no half-removed groups.
One thing worth confirming before merge: nearly all of the removed entries are full:<GPU>/... lines, which only run in post-merge/full test stages, so a standard /bot run on this PR won't exercise them. If the un-waive is wrong for any of them the failure lands on main's post-merge, not here. Worth a targeted run of the affected stages (or at least the ones with the largest blast radius — the TestGPTOSS::test_w4_* group on RTX_6000D / RTX_PRO_6000_Blackwell_Server_Edition, 20 entries from one bug) before this merges.
Also, the generator keys purely on bug closure. A bug can be closed without the specific waived test having been re-run green (closed as duplicate, closed unverified, closed as not-a-bug). If the job doesn't already do it, gating each removal on a recent passing result for that exact test ID would make these PRs safe to merge unattended.
|
PR_Github #64910 [ run ] completed with state
|
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/test_lists/waives.txt (1)
1-1: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winAdd the NVIDIA copyright header.
tests/integration/test_lists/waives.txtwas modified and has no NVIDIA header. Add the repository-standard SPDX header with year 2026, then run parser validation.Coverage: no
test-db/orqa/files changed; three entries were removed fromwaives.txt. CBTS artifacts are unavailable, so the verdict is needs follow-up.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` at line 1, Add the repository-standard NVIDIA SPDX copyright header for 2026 at the top of waives.txt, preserving the existing waiver entry below it, then run the repository’s parser validation for this file.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 1: Add the repository-standard NVIDIA SPDX copyright header for 2026 at
the top of waives.txt, preserving the existing waiver entry below it, then run
the repository’s parser validation for this file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 70f3d8e0-4cc6-402e-80bb-f933545d9ad5
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #64950 [ run ] triggered by Bot. Commit: |
|
PR_Github #64950 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #64976 [ run ] triggered by Bot. Commit: |
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
|
/bot run --skip-test |
|
PR_Github #65200 [ run ] triggered by Bot. Commit: |
|
PR_Github #64976 [ run ] completed with state |
|
PR_Github #65200 [ run ] completed with state |
|
/bot reuse-pipeline |
|
PR_Github #65252 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #65252 [ reuse-pipeline ] completed with state |
4 participants
Auto-generated Un-waive PR
Created by: TensorRT LLM CI (requested by qa@nvidia.com)
Target branch:
mainJenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_UPDATE_WAIVES/115/
Closed bug(s) un-waived: 5908070, 6075431, 6215684, 6248827, 6255417, 6273846, 6276983, 6301807, 6322073, 6400067, 6414760, 6418021, 6422339, 6423845, 6428087, 6440089, 6442073, 6463812, 6463822, 6463829, 6474892, 6475621, 6478645, 6482297, 6483370, 6490004, 6490043, 6501837, 6507102, 6517839, 6525007, 6525009, 6525892, 6526186, 6526429, 6528834, 6528837, 6529871, 6546605, 6547150, 6547151, 6551802, 6562582, 6563551
Waive entries removed
This PR was auto-generated by TensorRT LLM CI. Please review before merging.
Dev Engineer Review
tests/integration/test_lists/waives.txt.QA Engineer Review
test-db/orqa/files were modified.Verdict: needs follow-up