Skip to content

issue 683: fixing toolbar context menu translation - #687

Merged
AgreeDK merged 1 commit into
OpenSAK-Org:betafrom
urs-beeli:beta
Aug 2, 2026
Merged

issue 683: fixing toolbar context menu translation#687
AgreeDK merged 1 commit into
OpenSAK-Org:betafrom
urs-beeli:beta

Conversation

@urs-beeli

@urs-beeli urs-beeli commented Aug 2, 2026

Copy link
Copy Markdown

This is a bugfix for issue 683 (#683) where the context menu to show/hide the toolbar was not translated.

Changes I made:

  • removed the hard coded QToolBar name and using "tr("key")" instead
  • added the required translation entries to all language files
  • used the previously hard coded danish text in the danish language file
  • translated those two languages I speak fluently (english and german)
  • translated the other languages using ChatGPT (what is the "best practice" here? should I have left the Danish or English translation in those files, so the other translators can translate it themselves? or was my approach correct)?

Testing

  • pytest -v tests/ shows all test as passed
  • python run.py brought up the application, I could still import a GSAK database and the context menu was shown in the english translation

Environment

python --version = 3.14.6
os=Windows 11 Pro 25H2 64-bit German

@urs-beeli

Copy link
Copy Markdown
Author

Sorry about the superfluous line feed changes, I didn't knowingly make them, I'm not sure if IntelliJ autoformatted the files when saving and caused this... Let me know if you'd like me to revert those line feed changes.

@AgreeDK

AgreeDK commented Aug 2, 2026

Copy link
Copy Markdown
Member

Thanks for this, @urs-beeli — clean fix, and nice touch fixing the whitespace along the way too. All checks are green, merging now.

Welcome aboard as a contributor — looking forward to more! 🎉

@AgreeDK
AgreeDK merged commit c1eea79 into OpenSAK-Org:beta Aug 2, 2026
7 checks passed
AgreeDK added a commit that referenced this pull request Aug 2, 2026
   - Promote CHANGELOG [Unreleased] to dated v1.17.0-beta.2 entry
   - Toolbar title translation fix (#683, #687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants