feat(tup): migrate ad-hoc assets from tup-ui - #564
Merged
wesleyboar merged 4 commits intoAug 3, 2026
Conversation
Migrates the actual asset files that tup/html/css-ad-hoc-styles.html and js-ad-hoc-scripts.html link to, out of tup-ui's apps/tup-cms/src/taccsite_custom/tup_cms/static/tup_cms/css/ad-hoc/ and js/ad-hoc*. The snippet wrapper files were already migrated (#559, #560); this closes the loop so the ad-hoc snippets can point their CDN links at this repo instead of tup-ui. hide-blog-list-back-link.css (tup-ui#562, open) and adjust-logo.css (tup-ui#535, open) are not included — neither exists on tup-ui main yet.
wesleyboar
changed the title
…est pending edits navbar-width-horz-scrollbar.css: use tup-ui#535's trimmed version (drops rules migrated to Core-CMS), not the stale main version this PR originally copied. ad-hoc.js + manage-participants-field-required-attr.js (new): the live ad-hoc JS snippet is already pinned to tup-ui@0c0beee5 (a tup-ui#566 commit), so this repo's copy was stale/incomplete relative to what's actually live. Added the missing import and its target file, verified byte-identical to that pinned commit.
Both are open, unmerged tup-ui PRs (#562 and #535 respectively) that weren't on tup-ui main yet when this PR was first opened. Added now, verified byte-identical to each PR's current branch content. adjust-logo.css is #535's split-out of the logo/nav-sizing rules that used to live in navbar-width-horz-scrollbar.css (already synced here).
wesleyboar
changed the title
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Aug 3, 2026
Both are being moved to Core-CMS-Custom (TACC/Core-CMS-Custom#564); keep them untouched/absent here so tup-ui#571 doesn't conflict with this PR once it also deletes the ad-hoc JS files.
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Aug 3, 2026
Same as this PR's CSS deletions: these are now versioned in Core-CMS-Custom (TACC/Core-CMS-Custom#564) instead of here. tup-ui#566 (closed) had a pending edit to ad-hoc.js; it was reverted to zero diff and closed before this, so no conflict here.
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Aug 3, 2026
Now versioned in Core-CMS-Custom (TACC/Core-CMS-Custom#564) instead of here.
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Aug 3, 2026
…nd new adjust-logo.css Both are now versioned in Core-CMS-Custom (TACC/Core-CMS-Custom#564) instead of here; keep them untouched/absent here so tup-ui#571 doesn't conflict with this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Migrates CSS/JS assets (that
tup/html/css-ad-hoc-styles.htmlandjs-ad-hoc-scripts.htmlload) from TACC/tup-ui to here.Details
The snippets files were already migrated (#559, #560); this closes the loop so those snippets'
<link>/<script>tags can point at this repo's CDN pins instead of tup-ui's.Related
Important
Follow-up: Repoint
tup/html/css-ad-hoc-styles.htmlandjs-ad-hoc-scripts.html's CDN URLs at this repo (not done in this PR).Changes
tup/css/ad-hoc/(many files)tup/js/ad-hoc.jstup/js/ad-hoc/manage-participants-field-required-attr.jstup/css/ad-hoc/hide-blog-list-back-link.css(from fix(cms): hide blog list back link until Core-CMS upgrade tup-ui#562, open)tup/css/ad-hoc/adjust-logo.css(from refactor: manage CMS assets, delete outdated assets tup-ui#535, open)navbar-width-horz-scrollbar.cssTesting
navbar-width-horz-scrollbar.cssmatches refactor: manage CMS assets, delete outdated assets tup-ui#535's branchadjust-logo.cssmatches refactor: manage CMS assets, delete outdated assets tup-ui#535's branch (doesn't exist on tup-uimain)hide-blog-list-back-link.cssmatches fix(cms): hide blog list back link until Core-CMS upgrade tup-ui#562's branch (doesn't exist on tup-uimain)ad-hoc.js/manage-participants-field-required-attr.jsmatches the commit already pinned in the live snippet, TACC/tup-ui@0c0beee5