Update concat to immediately concatenate Consts, returning a new Const. - #502
Merged
Conversation
…`Const`. This removes many unnecessary `concats`, especially from the common `counter + 1` pattern. In this pattern, `as_wires` creates a 1-bit `Const` for the `1`, then `match_bitwidth` zero-extends the `Const` to `counter`'s bitwidth, which concatenates zeroes to the 1-bit `Const`. This `concat` is not useful, because the zeroes and the 1-bit `1` are all `Consts`. This commit removes these unnecessary `concats`. This significantly reduces the number of `concat` `LogicNets` in `pyrtlnet` (33%, 611 -> 412).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #502 +/- ##
=============================================
+ Coverage 93.8% 93.8% +0.1%
=============================================
Files 30 30
Lines 7166 7172 +6
=============================================
+ Hits 6716 6722 +6
Misses 450 450 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes many unnecessary
concats, especially from the commoncounter + 1pattern. In this pattern,as_wirescreates a 1-bitConstfor the1, thenmatch_bitwidthzero-extends theConsttocounter's bitwidth, which concatenates zeroes to the 1-bitConst. Thisconcatis not useful, because the zeroes and the 1-bit1are allConsts. This commit removes these unnecessaryconcats.This significantly reduces the number of
concatLogicNetsinpyrtlnet(33%, 611 -> 412).